Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure CONN_MAX_AGE #1570

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Configure CONN_MAX_AGE #1570

merged 1 commit into from
Oct 13, 2023

Conversation

actlikewill
Copy link
Contributor

@actlikewill actlikewill marked this pull request as ready for review October 11, 2023 09:36
longhotsummer
longhotsummer reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this an env variable? Im a bit nervous about deploying to everywhere at once since we haven't used it before. It also only applies in the cape where we use a proxy.

@actlikewill
Copy link
Contributor Author

@longhotsummer sounds good. I've set it as an env variable with default to zero

@actlikewill actlikewill merged commit 1c87a87 into main Oct 13, 2023
9 checks passed
@actlikewill actlikewill deleted the db-conn branch October 13, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure CONN_MAX_AGE on db connections
2 participants
@actlikewill @longhotsummer